Skip to content

Fix the package docker job in the release workflow #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Fix the package docker job in the release workflow #4003

merged 1 commit into from
Apr 10, 2025

Conversation

zhassan-aws
Copy link
Contributor

#3918 included this change to the release workflow:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index df2710ee3e0..244c8063f0c 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
       - name: 'Build release bundle'
         run: |
@@ -339,7 +336,7 @@ jobs:
         uses: docker/build-push-action@v6
         with:
           context: .
-          file: scripts/ci/Dockerfile.bundle-release-20-04
+          file: scripts/ci/Dockerfile.bundle-release-24-04
           push: true
           github-token: ${{ secrets.GITHUB_TOKEN }}
           tags: |

but the referenced file (scripts/ci/Dockerfile.bundle-release-20-04) was not renamed. This caused the package docker job to fail in the last release: https://github.com/model-checking/kani/actions/runs/14296758126/job/40065081063 with:

ERROR: failed to solve: failed to read dockerfile: open Dockerfile.bundle-release-24-04: no such file or directory

This PR renames the file and updates it to use Ubuntu 24.04.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

tautschnig
tautschnig approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! My bad, I had thought we anyway have the 24-04 file, but that of course was only true of "bundle-test-ubuntu-" not "bundle-release-".

@tautschnig tautschnig added this pull request to the merge queue Apr 10, 2025
Merged via the queue into model-checking:main with commit 0e4cab9 Apr 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhassan-aws @tautschnig