Skip to content

Pause/freeze containers during commit #6787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2014
Merged

Pause/freeze containers during commit #6787

merged 2 commits into from
Jul 1, 2014

Conversation

vieux
Copy link
Contributor

@vieux vieux commented Jul 1, 2014 •
edited by thaJeztah
Loading

@vieux
Pause/freeze containers during commit
17d870b 
Initiates a pause before committing a container,
adds a pause option to the commit command, defaulting to 'true'.

Fixes bug: moby#6267
Fixes bug: moby#3675

Docker-DCO-1.1-Signed-off-by: Eric Windisch <ewindisch@docker.com> (github: ewindisch)
@vieux
Copy link
Contributor Author

vieux commented Jul 1, 2014

ping @tiborvass @unclejack

@SvenDowideit can you take a look at my last commit please

SvenDowideit
SvenDowideit reviewed Jul 1, 2014
View reviewed changes
docs/sources/reference/commandline/cli.md
@@ -344,6 +345,11 @@ shell, or to export a working dataset to another server. Generally, it
is better to use Dockerfiles to manage your images in a documented and
maintainable way.

By default, the container being committed and its processes will be paused
during the process of committing the image. This reduces the likelihood of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change during the process of committing the image to while the image is committed - using process in 2 different ways in the same sentence is confusing

@SvenDowideit
Copy link
Contributor

Docs LGTM, with minor tweak - @jamtur01 @ostezer @fredlf

@tiborvass
Copy link
Contributor

LGTM minus @SvenDowideit's comments

@unclejack
Copy link
Contributor

LGTM

@vieux
updated docs & tests
957c510 
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
vieux added a commit that referenced this pull request Jul 1, 2014
@vieux
Merge pull request #6787 from vieux/pause_commit2
cdc62c7 
Pause/freeze containers during commit
@vieux vieux merged commit cdc62c7 into moby:master Jul 1, 2014
@vieux vieux deleted the pause_commit2 branch July 1, 2014 17:12
@unclejack unclejack mentioned this pull request Jul 9, 2014
Closed
@jessfraz jessfraz mentioned this pull request Feb 27, 2015
Closed
@thaJeztah thaJeztah mentioned this pull request Jan 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pause (freeze) container during 'commit' Docker exports/diff/commits are racy
4 participants
@vieux @SvenDowideit @tiborvass @unclejack