[28.x backport] daemon/server: remove compatibility with API v1.4 auth-config on push #50480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker [API v1.4] and lower expected registry authentication to be sent in
the request body when pushing or pulling ("creating") images. [API v1.5]
(Docker v0.6.1) changed this to this to use a `X-Registry-Auth` header
instead.
This change was implemented in d04beb7,
which kept a fallback for clients using old (< v1.5) API versions which
would send authentication in the request body.
Given that we no longer support API versions older than v1.24, and clients
using API v1.5 would be over 12 Years old.
[API v1.4]: https://github.com/moby/moby/blob/v0.6.1/docs/sources/api/docker_remote_api_v1.4.rst#push-an-image-on-the-registry
[API v1.5]: https://github.com/moby/moby/blob/v0.6.2/docs/sources/api/docker_remote_api_v1.5.rst#push-an-image-on-the-registry
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit ea29dff)
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
|
Probably fine for 28.3.3? |
|
Yeah, I think this should be fine; even worth considering including in the LTS branches; nothing should depend on this feature since ... 10+ Years, and it looks like the side-effects were worse than the benefits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker API v1.4 and lower expected registry authentication to be sent in the request body when pushing or pulling ("creating") images. API v1.5 (Docker v0.6.1) changed this to this to use a
X-Registry-Authheader instead.This change was implemented in d04beb7, which kept a fallback for clients using old (< v1.5) API versions which would send authentication in the request body.
Given that we no longer support API versions older than v1.24, and clients using API v1.5 would be over 12 Years old.
(cherry picked from commit ea29dff)
- What I did
Backports #50371 to 28.x stable branch.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)