integration-cli: TestCopyFromContainerPathIsNotDir: adjust for win 2025 #50189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the error returned by Windows changed in Windows 2025; before
Windows 2025, this produced a `ERROR_INVALID_NAME`;
The filename, directory name, or volume label syntax is incorrect.
But Windows 2025 produces a `ERROR_DIRECTORY` ("The directory name is invalid."):
CreateFile \\\\?\\Volume{d9f06b05-0405-418b-b3e5-4fede64f3cdc}\\windows\\system32\\drivers\\etc\\hosts\\: The directory name is invalid.
Docs; https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
99bf8eb to
d3d20b9
Compare
|
Wondering if someone has Windows 2025 (or equivalent) to check if this is indeed Windows changing the error returned, or if (e.g.) The intent of this test is to check for an error when trying to create a directory with a path-name that is a file. |
It's still there in mcr.microsoft.com/windows/nanoserver:ltsc2025 ... |
austinvazquez
approved these changes
Jun 12, 2025
robmry
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the error returned by Windows changed in Windows 2025; before Windows 2025, this produced a
ERROR_INVALID_NAME;But Windows 2025 produces a
ERROR_DIRECTORY("The directory name is invalid."):Docs; https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-
- A picture of a cute animal (not mandatory but encouraged)