Skip to content

Revert "containerd: images overridden by a build are kept dangling" #50105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Revert "containerd: images overridden by a build are kept dangling" #50105

merged 1 commit into from
May 30, 2025
+51 −53

Conversation

jsternberg
Copy link
Collaborator

@jsternberg jsternberg commented May 29, 2025 •
edited
Loading

This reverts commit 50a8561.

containerd image store: Fix a regression causing `docker build --push` to fail. This reverts [the fix](https://github.com/moby/moby/pull/49702) for `docker build` not persisting overridden images as dangling.

@jsternberg
Revert "containerd: images overridden by a build are kept dangling"
7994426 
This reverts commit 50a8561.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@jsternberg jsternberg requested a review from tonistiigi as a code owner May 29, 2025 18:24
@jsternberg jsternberg requested a review from vvoland May 29, 2025 18:25
@vvoland vvoland added kind/bugfix PR's that fix bugs area/builder/buildkit Build containerd-integration Issues and PRs related to containerd integration labels May 29, 2025
@vvoland vvoland added this to the 28.2.2 milestone May 29, 2025
vvoland
vvoland approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; updated the changelog description

@vvoland vvoland merged commit 45873be into moby:master May 30, 2025
248 of 250 checks passed
This was referenced May 30, 2025
Merged
Open
@jsternberg jsternberg deleted the revert-build-dangling branch May 30, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@vvoland vvoland vvoland approved these changes

Assignees
No one assigned
Labels
area/builder/buildkit Build containerd-integration Issues and PRs related to containerd integration impact/changelog kind/bugfix PR's that fix bugs
Projects
None yet
Milestone
28.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jsternberg @tonistiigi @vvoland