nftables: rules for the internal DNS resolver #50050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77388b4 to
f6e3127
Compare
dmcgowan
approved these changes
May 28, 2025
corhere
approved these changes
May 29, 2025
libnetwork/resolver_unix.go
Outdated
| @@ -16,14 +18,22 @@ const ( | |||
| postroutingChain = "DOCKER_POSTROUTING" | |||
| ) | |||
|
|
|||
| func (r *Resolver) setupIPTable() error { | |||
| func (r *Resolver) setupNAT() error { | |||
There was a problem hiding this comment.
Since you're already touching this function signature and all call sites, it seems like an ideal opportunity to do a touch of context plumbing.
Suggested change
| func (r *Resolver) setupNAT() error { | |
| func (r *Resolver) setupNAT(ctx context.Context) error { |
There was a problem hiding this comment.
This unexported method is only called from one (exported) method, which has no context. So it's a bit futile but, done.
Signed-off-by: Rob Murray <rob.murray@docker.com>
f6e3127 to
d3289dd
Compare
corhere
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When nftables is enabled, use nftables instead of iptables to redirect DNS requests from containers to the internal DNS resolver.
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)