Skip to content

Add riscv64 support to the build scripts #40664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Add riscv64 support to the build scripts #40664

merged 1 commit into from
Apr 3, 2020

Conversation

carlosedp
Copy link
Contributor

- What I did

Added riscv64 architecture support to the scripts used to build Docker
and it's dependencies.

- How I did it

Added support to build scripts.

- How to verify it

Run ./hack/make.sh binary on riscv64 host.

- Description for the changelog

Support riscv64 on the build scripts.

@carlosedp carlosedp requested a review from tianon as a code owner March 10, 2020 21:46
@carlosedp carlosedp changed the title Add support to riscv64 to the build scripts Add riscv64 support to the build scripts Mar 10, 2020
tianon
tianon reviewed Mar 10, 2020
View reviewed changes
tianon
tianon reviewed Mar 10, 2020
View reviewed changes
tianon
tianon reviewed Mar 10, 2020
View reviewed changes
cpuguy83
cpuguy83 approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member

Restarted CI a bunch of times, but had never passed in the three weeks 😕

@carlosedp
Copy link
Contributor Author

@AkihiroSuda Any idea if this is somewhat related to the change?

@AkihiroSuda
Copy link
Member

Could you try rebasing?

@carlosedp
Add support to riscv64 to the build scripts
7ac638f 
Added riscv64 architecture support to the scripts used to build Docker
and it's dependencies.

Signed-off-by: Carlos de Paula <me@carlosedp.com>
@AkihiroSuda
Copy link
Member 

[2020-04-03T17:37:18.399Z] Step 6/16 : RUN git clone "${BUILDX_REPO}" /buildx

[2020-04-03T17:37:18.399Z]  ---> Running in 3e4c53287c2c

[2020-04-03T17:37:18.39f9Z] Cloning into '/buildx'...

[2020-04-03T17:37:18.399Z] fatal: unable to access 'https://github.com/docker/buildx.git/': Could not resolve host: github.com

[2020-04-03T17:37:18.399Z] The command '/bin/sh -c git clone "${BUILDX_REPO}" /buildx' returned a non-zero code: 128

[2020-04-03T17:37:18.399Z] Makefile:288: recipe for target 'bundles/buildx' failed

[2020-04-03T17:37:18.399Z] make: *** [bundles/buildx] Error 128

The failure in ppc64le is obviously unrelated. Merging.

@AkihiroSuda AkihiroSuda merged commit 846b557 into moby:master Apr 3, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
impact/changelog status/4-merge
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@carlosedp @AkihiroSuda @tianon @cpuguy83 @thaJeztah