Skip to content

vendor: update buildkit to v0.18.0-rc2 #48952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

vendor: update buildkit to v0.18.0-rc2 #48952

merged 1 commit into from
Nov 26, 2024
+14 −10

Conversation

tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Nov 26, 2024 •
edited by thaJeztah
Loading

full diff: moby/buildkit@94d0f6e...v0.18.0-rc2

- What I did

- How I did it

- How to verify it

- Description for the changelog



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  




      

       
            



      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @tonistiigi
  




      

        
          vendor: update buildkit to v0.18.0-rc2
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          90250ce
        
      

    

  

    

      
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

    







  








      

  
            

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  28.0.0 milestone


      Nov 26, 2024

    

  



    







      

  
      



  

  @thaJeztah





  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        



  
    

      
          
Failure looks unrelated, but we should look at improving that test to also preserve the command output, because currently the error may not be very informative on failures; 

  

    

      moby/integration-cli/docker_cli_push_test.go
    

    

        Lines 150 to 160
      in
      2f6953f
    

  

  

    


        

          
           for _, repo := range repos { 
        


        

          
           	go func(repo string) { 
        


        

          
           		result := icmd.RunCommand(dockerBinary, "push", repo) 
        


        

          
           		results <- result.Error 
        


        

          
           	}(repo) 
        


        

          
           } 
        


        

          
            
        


        

          
           for range repos { 
        


        

          
           	err := <-results 
        


        

          
           	assert.NilError(c, err, "concurrent push failed with error: %v", err) 
        


        

          
           } 
        

    

  






=== Failed
=== FAIL: amd64.integration-cli TestDockerRegistrySuite/TestConcurrentPush (1.36s)
    docker_cli_push_test.go:159: assertion failed: error is not nil: exit status 1: concurrent push failed with error: exit status 1
    check_test.go:476: [dd03c91e2f0e7] daemon is not started
    --- FAIL: TestDockerRegistrySuite/TestConcurrentPush (1.36s)


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
          

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Nov 26, 2024
    





  


  

      
     Merged

  







  









      

  
        

  

      

  thaJeztah
  

  
          

            
                  thaJeztah
  

            

            approved these changes


            
                
                  Nov 26, 2024
                
            
            
          


          



              
    View reviewed changes
  


          





          

  
  
  
              

                      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      @thaJeztah

      
            thaJeztah
  

      

      

      left a comment




      
    


  



                  

                      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
LGTM

    

  
  




                    

                  
  
  

    
  
    
    

  

  

  



                      

                    
                  








      

  
  
  




  








      

  
          
 
  

    
  

  


        
        @thaJeztah
  thaJeztah



        merged commit d8fa058
      into

      
  
    moby:master
  


    Nov 26, 2024

      

        155 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Nov 27, 2024
    





  


  

      
     Merged

  





  
  

      
        
      
      


  
    
    
  


    5 tasks
  





  




    











  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @thaJeztah
  
    thaJeztah



    
      
        
      
    
    thaJeztah approved these changes

  


        

    


  
      @crazy-max
  
    crazy-max



    
      
        
      
    
    crazy-max approved these changes

  



      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    area/builder/buildkit

  Build
  

    area/builder

  Build
  

    process/cherry-picked

  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    28.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.



  
          
      dockerd fails to fully start with containerd snapshotter and many builds/images: context deadline exceeded



  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @tonistiigi 
        
          @thaJeztah 
        
          @crazy-max