Skip to content

Conversation

thaJeztah
Copy link
Member

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
aligning all related packages to v1.28.0 as well

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Oct 25, 2024

FWIW, not sure if it's still important to align "semconv" versions as well; here's what's currently used;

testutil/helpers.go                                                                                                        semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/github.com/containerd/containerd/tracing/tracing.go                                                                 semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/github.com/moby/buildkit/util/tracing/detect/resource.go                                                            semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/github.com/moby/buildkit/util/tracing/tracing.go                                                                    semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/config.go                               semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go                          semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/internal/parse.go                       semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/semconv.go                              semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go                        semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go                         semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/httptrace.go                           semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go       semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/netconv.go        semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/util.go                           semconvNew "go.opentelemetry.io/otel/semconv/v1.24.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/v1.20.0.go                           semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconv/v1.24.0.go                        semconvNew "go.opentelemetry.io/otel/semconv/v1.24.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go                      semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/netconv.go                       semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/transport.go:                                         semconv "go.opentelemetry.io/otel/semconv/v1.20.0"
vendor/go.opentelemetry.io/otel/sdk/resource/builtin.go                                                                    semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
vendor/go.opentelemetry.io/otel/sdk/resource/container.go                                                                  semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
vendor/go.opentelemetry.io/otel/sdk/resource/env.go                                                                        semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
vendor/go.opentelemetry.io/otel/sdk/resource/host_id.go                                                                    semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
vendor/go.opentelemetry.io/otel/sdk/resource/os.go                                                                         semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
vendor/go.opentelemetry.io/otel/sdk/resource/process.go                                                                    semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
vendor/go.opentelemetry.io/otel/sdk/trace/span.go                                                                          semconv "go.opentelemetry.io/otel/semconv/v1.26.0"

@thaJeztah
Copy link
Member Author

In the BuildKit repository it looks like this; looks like util/tracing is aligning with contrib/instrumentation there;

util/tracing/detect/resource.go:                                                                                      semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
util/tracing/tracing.go:                                                                                              semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/github.com/containerd/containerd/tracing/tracing.go:                                                           semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/config.go:                         semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go:                    semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/internal/parse.go:                 semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/semconv.go:                        semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go:                  semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go:                   semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/httptrace.go:                     semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go: semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/netconv.go:  semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/handler.go:                                      semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go:                semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/semconvutil/netconv.go:                 semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
vendor/go.opentelemetry.io/otel/exporters/jaeger/jaeger.go:                                                           semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/builtin.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/container.go:                                                            semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/env.go:                                                                  semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/host_id.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/os.go:                                                                   semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/resource/process.go:                                                              semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
vendor/go.opentelemetry.io/otel/sdk/trace/span.go:                                                                    semconv "go.opentelemetry.io/otel/semconv/v1.21.0"

@thaJeztah
Copy link
Member Author

Bringing this one in (after discussion on Slack, looks like this should be OK to go)

@thaJeztah thaJeztah merged commit 571d659 into moby:master Oct 29, 2024
172 checks passed
@thaJeztah thaJeztah deleted the bump_otel_v0.28_v0.53 branch October 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants