Skip to content

Conversation

thaJeztah
Copy link
Member

The userns package in libcontainer was integrated into the moby/sys/user module at commit 3778ae603c706494fd1e2c2faf83b406e38d687d.

The userns package is used in many places, and currently either depends on runc/libcontainer, or on containerd, both of which have a complex dependency tree. This patch is part of a series of patches to unify the implementations, and to migrate toward that implementation to simplify the dependency tree.

- A picture of a cute animal (not mandatory but encouraged)

full diff: moby/sys@user/v0.1.0...user/v0.2.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review July 25, 2024 09:49
@thaJeztah thaJeztah requested a review from cpuguy83 as a code owner July 25, 2024 09:49
The userns package in libcontainer was integrated into the moby/sys/user
module at commit [3778ae603c706494fd1e2c2faf83b406e38d687d][1].

The userns package is used in many places, and currently either depends
on runc/libcontainer, or on containerd, both of which have a complex
dependency tree. This patch is part of a series of patches to unify the
implementations, and to migrate toward that implementation to simplify
the dependency tree.

[1]: opencontainers/runc@3778ae6

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah merged commit 2b1097f into moby:master Jul 25, 2024
@thaJeztah thaJeztah deleted the migrate_userns branch July 25, 2024 12:06
@AkihiroSuda AkihiroSuda changed the title migrate to github.com/moby/sys/userns migrate to github.com/moby/sys/user/userns Jul 25, 2024
@thaJeztah
Copy link
Member Author

⚠️ after further discussion, we decided to move this package to a separate module instead of as part of the moby/sys/user module; we should get that change in before tagging a new release;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants