api/types/system: remove deprecated Info.ExecutionDriver #48111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The execution-driver was replaced with containerd since docker 1.11 (API v1.23) in 9c4570a, after which the value was no longer set. The field was left in the type definition. Commit 1fb1136 removed its use from the CLI and [docker-archive-public/docker.engine-api@39c7d7e] removed it from the API type, followed by an update to the API docs in 3c6ef4c. Changes to the API types were not pulled into the engine until v1.13, and probably because of that gated it on API version < 1.25 instead of < 1.24 (see 6d98e34); setting a "not supported" value for older versions. Based on the above; this field was deprecated in API v1.23, and empty since then. Given that the minimum API version supported by the engine is not v1.24, we can safely remove it. [docker-archive-public/docker.engine-api@39c7d7e]: docker-archive-public/docker.engine-api@39c7d7e Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution-driver was replaced with containerd since docker 1.11 (API v1.23) in 9c4570a, after which the value was no longer set. The field was left in the type definition. Commit 1fb1136 removed its use from the CLI and docker/engine-api@39c7d7e removed it from the API type, followed by an update to the API docs in 3c6ef4c.
Changes to the API types were not pulled into the engine until v1.13, and probably because of that gated it on API version < 1.25 instead of < 1.24 (see 6d98e34); setting a "not supported" value for older versions.
Based on the above; this field was deprecated in API v1.23, and empty since then. Given that the minimum API version supported by the engine is not v1.24, we can safely remove it.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)