-
Notifications
You must be signed in to change notification settings - Fork 18.8k
[do not merge] test CI with deprecated API-versions disabled #47149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cc764b
to
3bd57c3
Compare
…ootfs: use current API This test was added in 75f6929, but pinned to the API version that was current at the time (v1.20), which is now deprecated. Update the test to use the current API version. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
e348e6c
to
bc13901
Compare
…version This test was added in f301c57 to test inspect output for API > v1.21, however, it was pinned to API v1.21, which is now deprecated. Remove the fixed version, as the intent was to test "current" API versions (API v1.21 and up), Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This test was added in f301c57 to test inspect output for API > v1.21, however, it was pinned to API v1.21, which is now deprecated. Remove the fixed version, as the intent was to test "current" API versions (API v1.21 and up), Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These versions are deprecated in v25.0.0, and disabled by default, see 08e4e88. Users that need to refer to documentation for older API versions, can use archived versions of the documentation on GitHub: - API v1.23 and before: https://github.com/moby/moby/tree/v25.0.0/docs/api - API v1.17 and before: https://github.com/moby/moby/tree/v1.9.1/docs/reference/api Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These tables linked to deprecated API versions, and an up-to-date version of the matrix is already included at https://docs.docker.com/engine/api/#api-version-matrix Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
API versions before 1.19 allowed CpuShares that were greater than the maximum or less than the minimum supported by the kernel, and relied on the kernel to do the right thing. Commit ed39fbe introduced code to adjust the CPU shares to be within the accepted range when using API version 1.18 or lower. API v1.23 and older are deprecated, so we can remove support for this functionality. Currently, there's no validation for CPU shares to be within an acceptable range; a TODO was added to add validation for this option, and to use the `linuxMinCPUShares` and `linuxMaxCPUShares` consts for this. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
API v1.23 and older are deprecated, so we can remove the code to adjust responses for API v1.19 and lower. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
API v1.23 and older are deprecated, so we can remove the code to adjust responses for API v1.20. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
bc13901
to
e75f410
Compare
API v1.23 and older are deprecated, so we can remove the code to adjust responses for API v1.20 and lower. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
API v1.21 (Docker Engine v1.9.0) enforces the request to have a JSON content-type on exec start (see 45dc57f). An exception was added in 0b5e628 to make this check conditional (supporting API < 1.21). API v1.23 and older are deprecated, and this patch removes the feature. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This endpoint was deprecated in API v1.20 (Docker Engine v1.8.0) in commit db9cc91, in favor of the `PUT /containers/{id}/archive` and `HEAD /containers/{id}/archive` endpoints, and disabled in API v1.24 (Docker Engine v1.12.0) through commit 4283289. This patch removes the endpoint, and the associated `daemon.ContainerCopy` method in the backend. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Commit 322e2a7 changed the format of errors returned by the API to be in JSON format for API v1.24. Older versions of the API returned errors in plain-text format. API v1.23 and older are deprecated, so we can remove support for plain-text error responses. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…i < v1.24) API v1.20 (Docker Engine v1.11.0) and older allowed a HostConfig to be passed when starting a container. This feature was deprecated in API v1.21 (Docker Engine v1.10.0) in 3e7405a, and removed in API v1.23 (Docker Engine v1.12.0) in commit 0a8386c. API v1.23 and older are deprecated, and this patch removes the feature. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
e75f410
to
be4b5d7
Compare
closing in favour of #47155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)