Skip to content

client: deprecate old API versions #46962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

client: deprecate old API versions #46962

wants to merge 1 commit into from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 18, 2023 •
edited
Loading

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 25.0.0 milestone Dec 18, 2023
@thaJeztah
Copy link
Member Author

Need to looks at how we set API versions in some tests; looks like we do so including a v prefix (which current validation doesn't accept)


[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === Failed
[2023-12-18T18:57:28.211Z] === FAIL: client TestGetAPIPath (0.00s)
[2023-12-18T18:57:28.211Z]     client_test.go:180: assertion failed: error is not nil: API version must be provided without "v" prefix
[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === FAIL: client TestNegotiateAPIVersionEmpty (0.00s)
[2023-12-18T18:57:28.211Z]     client_test.go:272: assertion failed: 1.25 (string) != 1.24 (expected string)
[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === FAIL: client TestNegotiateAPIVersion/downgrade_from_default (0.00s)
[2023-12-18T18:57:28.211Z]     client_test.go:338: assertion failed: 1.21 (tc.expectedVersion string) != 1.44 (string)
[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === FAIL: client TestNegotiateAPIVersion/downgrade_legacy (0.00s)
[2023-12-18T18:57:28.211Z]     client_test.go:338: assertion failed: 1.24 (tc.expectedVersion string) != 1.44 (string)
[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === FAIL: client TestNegotiateAPIVersion/downgrade_old (0.00s)
[2023-12-18T18:57:28.211Z]     client_test.go:338: assertion failed: 1.19 (tc.expectedVersion string) != 1.44 (string)
[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === FAIL: client TestNegotiateAPIVersion (0.00s)
[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === FAIL: client TestNegotiateAPVersionOverride (0.00s)
[2023-12-18T18:57:28.211Z]     client_test.go:350: assertion failed: error is not nil: maximum supported API version is 1.44: 9.99
[2023-12-18T18:57:28.211Z] 
[2023-12-18T18:57:28.211Z] === FAIL: client TestOptionWithVersionFromEnv (0.00s)
[2023-12-18T18:57:28.211Z]     options_test.go:59: assertion failed: error is not nil: maximum supported API version is 1.44: 2.9999

@thaJeztah thaJeztah force-pushed the client_min_api_version branch 4 times, most recently from 562b552 to 77ba204 Compare December 18, 2023 20:27
@thaJeztah
Copy link
Member Author

Ah! 🤦 I forgot that DOCKER_API_VERSION (by "design") should accept "anything", including completely bogus versions;


[2023-12-18T20:29:28.187Z] === FAIL: client TestNegotiateAPVersionOverride (0.00s)
[2023-12-18T20:29:28.187Z]     client_test.go:360: assertion failed: error is not nil: maximum supported API version is 1.44: 9.99
[2023-12-18T20:29:28.187Z] 
[2023-12-18T20:29:28.187Z] === FAIL: client TestOptionWithVersionFromEnv (0.00s)
[2023-12-18T20:29:28.187Z]     options_test.go:59: assertion failed: error is not nil: maximum supported API version is 1.44: 2.9999

I guess (for now) I need to keep that behavior

corhere
corhere reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this wait until after we migrate moby/moby to Go Modules? We'd then be able to drop support for old API versions and remove code without deprecation periods, environment variables(!!!) or putting downstream users through dependency hell.

@thaJeztah thaJeztah mentioned this pull request Dec 19, 2023
Merged
@thaJeztah thaJeztah removed this from the 25.0.0 milestone Jan 3, 2024
@thaJeztah
client: deprecate old API versions
2efcb8f 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the client_min_api_version branch from 77ba204 to 2efcb8f Compare February 7, 2024 01:41
@thaJeztah thaJeztah mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corhere corhere corhere left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/api area/cli impact/api impact/changelog status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @corhere