c8d/integration-cli: Skip part of TestListDanglingImagesWithDigests #46868
Conversation
| @@ -341,6 +341,13 @@ func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) { | |||
| // make sure repo shown, tag=<none>, digest = $digest1 | |||
| re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`) | |||
There was a problem hiding this comment.
Is this case already covered by TestListImagesWithDigests above?
If it is, it may be cleaner to t.Skip() the whole test
There was a problem hiding this comment.
Maybe this one test is actually multiple sub-tests 🤔 we could make sub-tests and skip those, but I guess we'd have to (temporarily) disable the "integration-cli is deprecated" check.
There was a problem hiding this comment.
Yeah, looks the same.
Let's just skip the whole test.
96797e1 to
308825c
Compare
| @@ -341,6 +344,7 @@ func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *testing.T) { | |||
| // make sure repo shown, tag=<none>, digest = $digest1 | |||
| re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`) | |||
| assert.Assert(c, re1.MatchString(out), "expected %q: %s", re1.String(), out) | |||
|
|
|||
There was a problem hiding this comment.
oh! unrelated change (if you still have the branch open locally)
There was a problem hiding this comment.
No worries! Thought you still had the branch at hand, so would be easy to fix (and wouldn't have been a massive disaster if it was left)
Skip TestListDanglingImagesWithDigests which tests graphdriver implementation specific behavior of `docker images --filter dangling=true`. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
308825c to
fcb89da
Compare
danglingfilter behavior #46856- What I did
Skip part of TestListDanglingImagesWithDigests which tests graphdriver implementation specific behavior of
docker images --filter dangling=true.- How I did it
- How to verify it
Check TestListDanglingImagesWithDigests test result
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)