Skip the busybox digest check when containerd is enabled #46758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always have a digest with containerd. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
thaJeztah
approved these changes
Nov 2, 2023
| // We always have a digest when using containerd to store images | ||
| if !testEnv.UsingSnapshotter() { | ||
| // make sure busybox has tag, but not digest | ||
| busyboxRe := regexp.MustCompile(`\s*busybox\s*latest\s*<none>\s`) |
There was a problem hiding this comment.
Oh man; this is so fiddly. This test is really in need of an update / migration to the integration/ suite
There was a problem hiding this comment.
Yeah, this one would be way nicer in integration...
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Skipped the busybox digest check when containerd is enabled since we always have a digest
- How I did it
- How to verify it
TestListImagesWithDigestsshould pass now.$ make DOCKER_GRAPHDRIVER=overlayfs TEST_FILTER=TestListImagesWithDigests TEST_INTEGRATION_USE_SNAPSHOTTER=1 TEST_IGNORE_CGROUP_CHECK=1 test-integration- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)