Skip to content

Conversation

jphuynh
Copy link
Contributor

@jphuynh jphuynh commented Apr 18, 2017

Signed-off-by: Jean-Pierre Huynh jean-pierre.huynh@ounet.fr

- What I did
Updated Dockerfiles and tests

- How I did it
Changed to the preferred LABEL solution.

- How to verify it
docker/builder/parser tests should pass

- Description for the changelog
MAINTAINER deprecation follow up. Relates to #25466

- A picture of a cute animal (not mandatory but encouraged)
cute-baby-seal

Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have a test somewhere testing the MAINTAINER keyword/command? Even though it's deprecated, wondering if we should change the tests for this

@jphuynh
Copy link
Contributor Author

jphuynh commented Apr 27, 2017

The tests have been changed accordingly in the same commit to reflect the changes in the Dockerfiles.

@thaJeztah thaJeztah merged commit 20255ad into moby:master May 13, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.06.0 milestone May 13, 2017
@jphuynh jphuynh deleted the more-maintainer-deprecation branch May 15, 2017 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants