bump libnetwork. vishvananda/netlink 1.0, vishvananda/netns #39054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aca0d46 to
aacdec2
Compare
This comment has been minimized.
This comment has been minimized.
aacdec2 to
fee96d2
Compare
thaJeztah
commented
Apr 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #39054 +/- ##
=========================================
Coverage ? 36.9%
=========================================
Files ? 612
Lines ? 45338
Branches ? 0
=========================================
Hits ? 16731
Misses ? 26321
Partials ? 2286 |
full diffs: - moby/libnetwork@fc5a7d9...62a13ae - vishvananda/netlink@b2de5d1...v1.0.0 - vishvananda/netns@604eaf1...13995c7 notable changes in libnetwork: - moby/libnetwork#2366 Bump vishvananda/netlink to 1.0.0 - moby/libnetwork#2339 controller: Check if IPTables is enabled for arrangeUserFilterRule - addresses moby/libnetwork#2158 dockerd when run with --iptables=false modifies iptables by adding DOCKER-USER - addresses moby#35777 With iptables=false dockerd still creates DOCKER-USER chain and rules - addresses docker/for-linux#136 dockerd --iptables=false adds DOCKER-USER chain and modify FORWARD chain anyway - moby/libnetwork#2394 Make DNS records and queries case-insensitive - addresses moby#28689 Embedded DNS is case-sensitive - addresses moby#21169 hostnames with new networking are case-sensitive Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
fee96d2 to
344b093
Compare
tiborvass
approved these changes
Jun 27, 2019
tiborvass
reviewed
Jun 29, 2019
| github.com/vishvananda/netns 604eaf189ee867d8c147fafc28def2394e878d25 | ||
| github.com/vishvananda/netlink b2de5d10e38ecce8607e6b438b6d174f389a004e | ||
| github.com/vishvananda/netns 13995c7128ccc8e51e9a6bd2b551020a27180abd | ||
| github.com/vishvananda/netlink a2ad57a690f3caf3015351d2d6e1c0b95c349752 # v1.0.0 |
There was a problem hiding this comment.
@thaJeztah FYI I just realized that this is not v1.0.0. Maybe we want to keep that in mind for cherry-picking.
There was a problem hiding this comment.
I just double checked, but looks like this commit matches the v1.0.0 tag? vishvananda/netlink@a2ad57a
There was a problem hiding this comment.
omg... they have a v1.0.0 branch that's not the tag...
There was a problem hiding this comment.
opened vishvananda/netlink#465
There was a problem hiding this comment.
oooooooh!
I wonder which one vndr picks if we don't specify the sha 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diffs:
notable changes in libnetwork: