Remove the rest of v1 manifest support #37874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rogaha |
da0f71b to
b7f475e
Compare
|
👍 on making this change. This is doing a couple things that are worth noting, it is completely removing the ability to pull from a v1 registry, removing the ability to push schema 1 (deprecating some early versions of the v2 registry and might still break push to quay.io), and changing the engine ID which was once used by classic swarm but not sure if it still relies on this. |
f712198 to
1b38c9e
Compare
Codecov Report
@@ Coverage Diff @@
## master #37874 +/- ##
==========================================
- Coverage 36.49% 36.44% -0.05%
==========================================
Files 613 613
Lines 45886 45827 -59
==========================================
- Hits 16746 16703 -43
+ Misses 26847 26842 -5
+ Partials 2293 2282 -11 |
|
Actually; can we also remove this from the Dockerfile Lines 50 to 57 in 20e8572 |
As people are using the UUID in `docker info` that was based on the v1 manifest signing key, replace with a UUID instead. Remove deprecated `--disable-legacy-registry` option that was scheduled to be removed in 18.03. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
97ad353 to
13b7d11
Compare
|
Updated to remove the schema1 registry build. |
AkihiroSuda
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As people are using the UUID in
docker infothat was based on the v1 manifest signing key, replacewith a UUID instead.
Remove deprecated
--disable-legacy-registryoption that was scheduled to be removed in 18.03.Signed-off-by: Justin Cormack justin.cormack@docker.com
fix #33356
closes #35479
Note this does not yet remove libtrust as docker/distribution is still using it.