Windows: Allow API v1.24 #28072
Merged
Windows: Allow API v1.24 #28072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Nov 4, 2016
| const MinVersion string = "1.25" | ||
| // Technically the first daemon API version released on Windows is v1.25 in | ||
| // engine version 1.13. However, some clients are explicitly using downlevel | ||
| // APIs (eg docker compose v2.1) and that is just too restrictive. Hence |
There was a problem hiding this comment.
We may want to explain this is the docker-compose 2.1 file format, not the version of docker compose
|
LGTM |
Signed-off-by: John Howard <jhoward@microsoft.com>
|
This should fix docker/compose#4106, testing |
|
@PatrickLang did it work? |
|
@friism yes, with a caveat. see docker/compose#4106 and friism/MusicStore#3 ;) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
@PatrickLang @thaJeztah
As per conversations, dropping the minimum API version on Windows to v1.24 to allow docker compose v2.1 to work against the Windows engine.