Skip to content

Windows: Require REST 1.25 or later #27908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2016
Merged

Windows: Require REST 1.25 or later #27908

merged 1 commit into from
Nov 1, 2016

Conversation

lowenna
Copy link
Member

@lowenna lowenna commented Oct 31, 2016 •
edited
Loading

Signed-off-by: John Howard jhoward@microsoft.com

Fixes #27601.

@thaJeztah Windows support doesn't start until API version 1.25.

@lowenna lowenna force-pushed the jjh/fix27601APIVersion branch from c996893 to f64f889 Compare October 31, 2016 17:19
@lowenna lowenna added this to the 1.13.0 milestone Oct 31, 2016
@thaJeztah
Copy link
Member

/cc @bfirsh @vieux PTAL as well

thaJeztah
thaJeztah approved these changes Oct 31, 2016
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once green 😄)

@lowenna lowenna force-pushed the jjh/fix27601APIVersion branch 3 times, most recently from 575c56f to 9a4a7fe Compare October 31, 2016 20:51
@lowenna
Copy link
Member Author

lowenna commented Oct 31, 2016

Think I've got them all now 😅

Windows: Require REST 1.25 or later
f811d5b 
Signed-off-by: John Howard <jhoward@microsoft.com>
@lowenna lowenna force-pushed the jjh/fix27601APIVersion branch from 9a4a7fe to f811d5b Compare October 31, 2016 21:34
@lowenna
Copy link
Member Author

lowenna commented Oct 31, 2016

Yay. All green 💚

crosbymichael
crosbymichael approved these changes Nov 1, 2016
View reviewed changes
Copy link
Contributor

@crosbymichael crosbymichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael crosbymichael merged commit 70459d6 into moby:master Nov 1, 2016
@lowenna lowenna deleted the jjh/fix27601APIVersion branch November 1, 2016 22:26
This was referenced Nov 2, 2016
Merged
Merged
@samuelkarp samuelkarp mentioned this pull request Mar 13, 2017
Closed
@richardpen richardpen mentioned this pull request Aug 24, 2017
Closed
@thaJeztah thaJeztah mentioned this pull request Jan 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@crosbymichael crosbymichael crosbymichael approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lowenna @thaJeztah @crosbymichael @GordonTheTurtle