gha cache: reload expired cache URLs #6053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable. |
In some conditions there can be a pause between initial load of the entry (that already contains signed download URL even though we don't need it yet) and by the time cache is actually downloaded in the end of the build. One such case seems to be accessing SBOM scanner layers after the main build is completed. Signed URL is only valid for 10min and if more time has passed then old URL may receive 403 error. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
4f65e2d to
bdfc809
Compare
|
Upstream PR was merged. |
crazy-max
approved these changes
Jun 26, 2025
cpuguy83
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some conditions, there can be a pause between the initial load of the entry (that already contains a signed download URL even though we don't need it yet) and the time the cache blob is actually downloaded at the end of the build. One such case seems to be accessing SBOM scanner layers after the main build is completed. The signed URL is only valid for 10 minutes, and if more time has passed, then the old URL may receive a 403 error.
upstream version tonistiigi/go-actions-cache#40