cdi: fix device request by class annotation #5969
Merged
+36
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
May 14, 2025
|
Haven't fully grasped the change, but is this something that's also needed on the engine side (for CDI)? |
Atm the annotation is buildkit specific, so no quick change needed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #5923 (review)
Current logic to find devices by class annotation was not correct. Now user can just specify the class of the device without it being a device qualifer so it handles multiple CDI specs registered.