Ignore com.apple. extended file attributes in contenthash
#5899
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Michael <tylermichael@users.noreply.github.com>
|
This should be done in the xattr loader loadXattr https://github.com/moby/buildkit/blob/master/vendor/github.com/tonistiigi/fsutil/stat_unix.go#L15 or in the client side Map function https://github.com/moby/buildkit/blob/master/vendor/github.com/tonistiigi/fsutil/filter.go#L33 passed by buildkit when running the transfer of local files. |
|
I tried my hands at putting this into I'm not sure if here or in the buildkit client is more appropriate for this functionality, but I figure that it probably doesn't overly matter that much. |
|
@jsternberg Your PR was merged so you can update the vendor to close this. |
|
I'll leave this open as a placeholder until @jsternberg is able to create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the correct location to make this change, but this PR attempts to fix docker/for-mac#7636 by ignoring
com.apple.extended file attributes in the file content hash.I feel like this is an appropriate action to take because I don't believe extended file attributes are enabled in the linux Docker VM filesystem on Mac, so Mac specific file attributes should not even be taken into account when calculating content hashes.