bklog: always enable trace id if it exists #5315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version of the detect package would only enable trace ids in the build log if tracing was in use. For practical purposes, there was always a tracer in use (either the recorder which was always enabled or one of the detected tracers). When this package was refactored, the call to enable the trace id was accidentally removed. This removes the option to enable or disable the trace id from the log and instead just always enables it since this was the behavior previously. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
tonistiigi
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of the detect package would only enable trace ids in the build log if tracing was in use. For practical purposes, there was always a tracer in use (either the recorder which was always enabled or one of the detected tracers).
When this package was refactored, the call to enable the trace id was accidentally removed.
This removes the option to enable or disable the trace id from the log and instead just always enables it since this was the behavior previously.
Fixes #5310.