cniprovider: support rootlesskit --detach-netns (RootlessKit v2)
#4546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b002bf3 to
cc3f31b
Compare
c389b7f to
1dcd54c
Compare
|
Rebased |
|
@tonistiigi Can we have a new beta after merging this? |
1dcd54c to
f648b17
Compare
RootlessKit v2 added the support for `--detach-netns` mode. This leaves containerd and buildkitd in the host netns so as to: - Eliminate the slirp overhead for pull/push - Allow accessing the real localhost registry. Since rootless users has no `CAP_NET_ADMIN` in the host netns, CNI plugins have to be executed in the "detached" netns (`$ROOTLESSKIT_STATE_DIR/netns`) that is associated with slirp. ref: - rootless-containers/rootlesskit PR 379 - containerd/nerdctl PR 2723 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
f648b17 to
d844974
Compare
|
Rebased |
tonistiigi
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RootlessKit v2 added the support for
--detach-netnsmode.This leaves containerd and buildkitd in the host netns so as to:
Since rootless users has no
CAP_NET_ADMINin the host netns, CNI plugins have to be executed in the "detached" netns ($ROOTLESSKIT_STATE_DIR/netns) that is associated with slirp.ref: