fix lease management with flightcontrol #4529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05abc3f to
55d2110
Compare
|
@ktock Can you take a quick look at these "missing lease requirement" errors for stargz. I can easily remove this validation in |
|
Thanks for pinging me. According to the stack trace, the error comes from |
When one flightcontrol callback gets canceled ctx.Value() stops working for aquiring leases for remaining callbacks. While this behavior should be also looked at more carefully, returning a lease for the first callback or for remaining callback would not be correct as some objects can be tracked by first lease and that lease could be already deleted by the first callpath. This fixes it so that any object tracked by flightcontrol callback will be copied to the lease of every codepath after the callback has returned. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
55d2110 to
4339ee5
Compare
ktock
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4419
When one flightcontrol callback gets canceled
ctx.Value() stops working for aquiring leases for
remaining callbacks. While this behavior should be also looked at more carefully, returning a lease for the first callback or for the remaining callback would not be correct as some objects can be tracked by first lease and that lease could be already deleted by the first callpath.
This fixes it so that any object tracked by flightcontrol callback will be copied to the lease of every codepath after the callback has returned.