diff: gzip with custom level should be compressed by BuildKit's differ #4275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
|
The tests of #4210 pass with this PR (tested in #4276 ). https://github.com/moby/buildkit/actions/runs/6299489743/job/17100420013?pr=4276#step:8:1259
@tonistiigi This patch will unblock PR #4210 , PTAL 🙏 |
tonistiigi
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4210 (comment)
With containerd worker + non-overlayfs-snapshotter configuration, we've been using containerd's differ via containerd client but the compression level can't be applied in this configuration. This commit fixes this issue by compressing gzip with customized compression level on BuildKit't differ instead of containerd's differ. Uncompressed blobs and gzip blobs without customized compression level are still handled by containerd's differ.