Skip to content

buildctl: propagate SOURCE_DATE_EPOCH from client env to build arg #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2023
Merged

buildctl: propagate SOURCE_DATE_EPOCH from client env to build arg #4231

merged 1 commit into from
Sep 15, 2023
+28 −3

Conversation

AkihiroSuda
Copy link
Member

Fix #4227

@AkihiroSuda AkihiroSuda marked this pull request as draft September 14, 2023 16:08
@AkihiroSuda AkihiroSuda marked this pull request as ready for review September 14, 2023 16:10
@thaJeztah
Copy link
Member

does buildx also have this (and if not, perhaps it should as well?)

@AkihiroSuda
Copy link
Member Author

does buildx also have this (and if not, perhaps it should as well?)

Yes

@thaJeztah
Copy link
Member

Oh, thanks! (I initially thought I was looking at the buildx repo, the realized this was buildkit - hence my question ☺️)

thaJeztah
thaJeztah approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM (nb)

tonistiigi
tonistiigi reviewed Sep 15, 2023
View reviewed changes
@AkihiroSuda
buildctl: propagate SOURCE_DATE_EPOCH from client env to build arg
b40359f 
Fix issue 4227

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda merged commit 3551ef6 into moby:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
area/cli buildctl CLI area/reproducible-builds kind/enhancement needs/docs-follow-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buildctl: consider propagating SOURCE_DATE_EPOCH from client env to build arg by default
4 participants
@AkihiroSuda @thaJeztah @tonistiigi @crazy-max