Fix: Fail to check go-ios installation #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reported issue #118 |
|
@codeaholicguy thanks for this pull request!! merged in, after a bit of time :) thanks for the patience. let's release a new version with this just one fix 🚀 |
|
thank you @gmegidish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was an async/await mismatch in the iOS device management code that was causing the application to fail when checking for go-ios installation and listing iOS devices.
Error:
The issue occurred because:
isGoIosInstalled()was incorrectly marked asasyncdespite using synchronousexecFileSyncSolution
Fixed the async/await pattern consistency:
Made
isGoIosInstalled()synchronous. Removedasynckeyword andPromise<boolean>return type since it usesexecFileSync()which is inherently synchronousImpact
mobile_list_available_devicesTesting
Able to get available devices when calling
mobile_list_available_devices.