Skip to content

Conversation

benlmyers
Copy link
Contributor

@benlmyers benlmyers commented Jun 11, 2025

Introduces three new parameters to the swipe_on_screen mcp tool. Adds left and right swiping.

  • direction: left, right, up, or down
  • distance: Distance to swipe in pixels. Default is 30% of screen width/height.
  • x: The x-coordinate of the position to start the swipe gesture
  • y: The y-coordinate of the position to start the swipe gesture

Default x and y parameters depend on swipe direction.

Testplan

  • iOS default swipe up+down works like before
  • Android default swipe up+down works like before
  • iOS swipe left+right works
  • Android swipe left+right works
  • iOS swipe distance works
  • Android swipe distance works
  • iOS swipe from coords works
  • Android swipe from coords works

iOS video >> https://drive.google.com/file/d/1o6WGRoNt3oNrd1bI_L0tT3NrYkOSpLxo/view?usp=drive_link
Android video >> https://drive.google.com/file/d/1EzJ6EJZqMSsqEwev5_ileUJQNSm64phW/view?usp=drive_link

@benlmyers benlmyers marked this pull request as ready for review June 11, 2025 15:42
@gmegidish
Copy link
Member

@benlmyers oh my! this is a beautiful pull request! I'll give it a look in the next couple of days. thank you so much for this!

@gmegidish
Copy link
Member

oh, video links expired :<

@benlmyers
Copy link
Contributor Author

Ah sorry, I'll get them reloaded in the next few hrs

@benlmyers
Copy link
Contributor Author

Updated

@gmegidish
Copy link
Member

@benlmyers

I want to first address the professionalism gone into this pull-request, I think you deserve it:

  1. You added missing error handling code. Notifying back if wda failed /actions command. This is great!
  2. You used existing swipe tool, as to keep old prompts working as they did in the past.
  3. You manually tested and provided proof that this new code works properly on both platforms.
  4. Added missing DELETE to /actions, how did I miss that???
  5. Optimization of getScreenSize if already having a wda session. Lovely!

Everything looks great! I'm going to merge this now, and test the whole platform again with the other 2 pull requests that were merged earlier. Thank you so much for this freaking kickass of a pull request 🤘

@gmegidish gmegidish merged commit afe162f into mobile-next:main Jun 16, 2025
1 check failed
@gmegidish gmegidish mentioned this pull request Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants