-
Notifications
You must be signed in to change notification settings - Fork 443
[Feature] Random text, number, person name or email #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Random text, number, person name or email #256
Conversation
maestro-orchestra-models/src/main/java/maestro/orchestra/util/InputTextRandom.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It mostly looks good with few minor comments on the API
@dmitry-zaitsev Thank you for your review. I will refactore my source code. |
@dmitry-zaitsev Please help me review this PR again when you are free. Sorry for any mistakes. English is not my native language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
@ttpho could you please share your Twitter and/or LinkedIn profile so that we can give you a proper shout out? |
@dmitry-zaitsev Thank you for your review and approval 🙇 I wrote an article about |
Proposed Changes
added command input random:
Testing
MaestroCommandSerializationTest.kt
IntegrationTest.kt
Issues Fixed