Update Android aritfacts to support 16kb page sizes #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
951b378 to
44ec221
Compare
|
@WhosNickDoglio thanks for looking into this! Is this ready for review? |
268ccd0 to
44ec221
Compare
44ec221 to
a685387
Compare
|
@Raibaz Yes sorry I was just doing some more testing since I'm not super familiar with cmake files or the required change but the lint error is gone from my project and all tests still pass so I think this can be reviewed 👍 |
Rawa
added a commit
to mullvad/mullvadvpn-app
that referenced
this pull request
May 24, 2025
Will be fixed in an upcoming version, see: mockk/mockk#1394
Rawa
added a commit
to mullvad/mullvadvpn-app
that referenced
this pull request
May 26, 2025
Will be fixed in an upcoming version, see: mockk/mockk#1394
Rawa
added a commit
to mullvad/mullvadvpn-app
that referenced
this pull request
May 26, 2025
Will be fixed in an upcoming version, see: mockk/mockk#1394
Rawa
added a commit
to mullvad/mullvadvpn-app
that referenced
this pull request
May 26, 2025
Will be fixed in an upcoming version, see: mockk/mockk#1394
|
Thanks! |
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1392
https://developer.android.com/guide/practices/page-sizes#compile-16-kb-alignment