Fix returning result values #1352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last version that worked for me with returned
Result
classes was 1.13.9. I've checked all the commits that were added between1.13.1
and1.13.10
and realized that this change was responsible for this behavior.I've reverted changes, at it looks like all tests are passing (even those added in the below PR that was causing issues). I think the change is not needed anymore and can be simply reverted
However I tested it mostly with
Result
class, so alternatively I can change this PR to only include workaround forResult
:This PR fixes: #1351, #1338