Fix capture using mutable list of value class #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `boxCast`, in the same way as `CapturingSlotMatcher` does.
|
Nice one, thanks for catching this and taking the time to look into it! |
sksamuel
referenced
this pull request
in kotest/kotest
Mar 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.mockk:mockk](https://mockk.io) ([source](https://togithub.com/mockk/mockk)) | `1.13.9` -> `1.13.10` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mockk/mockk (io.mockk:mockk)</summary> ### [`v1.13.10`](https://togithub.com/mockk/mockk/releases/tag/1.13.10) [Compare Source](https://togithub.com/mockk/mockk/compare/1.13.9...1.13.10) #### What's Changed - Add support to nested value classes by [@​rotilho](https://togithub.com/rotilho) in [https://github.com/mockk/mockk/pull/1202](https://togithub.com/mockk/mockk/pull/1202) - Fix callOriginal on default interface method by [@​flapenna](https://togithub.com/flapenna) in [https://github.com/mockk/mockk/pull/1203](https://togithub.com/mockk/mockk/pull/1203) - Only unbox value class answers when appropriate by [@​jselbo](https://togithub.com/jselbo) in [https://github.com/mockk/mockk/pull/1204](https://togithub.com/mockk/mockk/pull/1204) - Fix capture using mutable list of value class by [@​ath0s](https://togithub.com/ath0s) in [https://github.com/mockk/mockk/pull/1209](https://togithub.com/mockk/mockk/pull/1209) - Updates documentation to include example access error workaround for Android users by [@​JakeSteam](https://togithub.com/JakeSteam) in [https://github.com/mockk/mockk/pull/1211](https://togithub.com/mockk/mockk/pull/1211) #### New Contributors - [@​rotilho](https://togithub.com/rotilho) made their first contribution in [https://github.com/mockk/mockk/pull/1202](https://togithub.com/mockk/mockk/pull/1202) - [@​jselbo](https://togithub.com/jselbo) made their first contribution in [https://github.com/mockk/mockk/pull/1204](https://togithub.com/mockk/mockk/pull/1204) - [@​ath0s](https://togithub.com/ath0s) made their first contribution in [https://github.com/mockk/mockk/pull/1209](https://togithub.com/mockk/mockk/pull/1209) - [@​JakeSteam](https://togithub.com/JakeSteam) made their first contribution in [https://github.com/mockk/mockk/pull/1211](https://togithub.com/mockk/mockk/pull/1211) **Full Changelog**: mockk/mockk@1.13.9...1.13.10 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kotest/kotest). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When using
capturewith a mutable list of a value type (i.e. usingCaptureMatcher), the wrapped value is captured rather than the value type:When using
capturewith aslot(i.e. usingCapturingSlotMatcher) this is handled by calling the internalboxCasthelper function.The Solution
Use
boxCastinCaptureMatcher, in the same way asCapturingSlotMatcherdoes.