fix(813): Handle nullable value classes #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mockk#813 Problem: When trying to mock a function that returns a nullable value class, a ClassCastException was thrown. Thats because mockk is using the boxedClass. Nullable value classes should be handled differently because they are not inlined. Implementation: When the return type of the function or a member property is nullable do not use the boxedClass but use the value class itself fix
|
Thanks for looking into this! |
|
I think this might have broken some of my testcases which worked with 1.13.12. @JvmInline
private value class MyId(private val id: String)
private interface Y {
suspend fun getId(): MyId?
}
private class X(private val y: Y) {
suspend fun doStuff(): MyId? = y.getId()
}
@Test
fun `test stuff`() {
val mocked = mockk<Y>()
coEvery { mocked.getId() } returns MyId("987")
runBlocking { X(mocked).doStuff() } shouldBe MyId("987")
}Error message: |
3 tasks
|
You are right @dadadom, it seems to be a regression due to my change. I will attempt to fix the regression once I find sometime. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #813
Problem:
When trying to mock a function that returns a nullable value class, a ClassCastException was thrown. Thats because mockk is using the boxedClass. Nullable value classes should be handled differently because they are not inlined.
For example
Caused by: java.lang.ClassCastException: class java.lang.Integer cannot be cast to class io.mockk.it.ValueClassTest$Companion$DummyValue (java.lang.Integer is in module java.base of loader 'bootstrap'; io.mockk.it.ValueClassTest$Companion$DummyValue is in unnamed module of loader 'app')Implementation:
When the return type of the function or a member property is nullable do not use the boxedClass but use the value class itself