Fixes #838 : Adds a matches(Pattern) #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mockito/core Since the PR is fairly in scope amd fairly straightforward limited I'll merge it right away. |
Absolutely. Updating the public API needs review from other team mates but in this case it's best to move fast. It's an overloaded method, very natural complement to the existing one. Thanks @bric3! |
|
Yes exactly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #838 it is sensible to add a mockito matcher that can take a
Patternas an argument.The usage is the same as
matches(String).Although it allows to build more complex regex, especially with regular expression flags.