Added missing Javadoc and few other tidy-ups #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mockitoguy
commented
Dec 23, 2016
- No API / no behavior changes.
- Publicly visible changes:
- Added missing Javadoc and updated an existing one for MockitoException and MockitoAssertionError classes
- Remaining changes, refactoring:
- Rename job for consistency
- Removed some unnecessary code
- Made the tests more stable
It's already included in the interface hierarchy
'Impl' postfix in the interface name is very awkward
Also tweaked existing javadoc
This fixes recently introduced flakiness of the build.
Current coverage is 86.57% (diff: 100%)
|
bric3
reviewed
Dec 23, 2016
| @@ -17,7 +17,7 @@ public void shouldCreateRunnerInstance() throws Throwable { | |||
| //given | |||
| RunnerProvider provider = new RunnerProvider(); | |||
| //when | |||
| RunnerImpl runner = provider.newInstance("org.mockito.internal.runners.SilentJUnitRunner", this.getClass(), null); | |||
| InternalRunner runner = provider.newInstance("org.mockito.internal.runners.DefaultInternalRunner", this.getClass(), null); | |||
There was a problem hiding this comment.
Since the runner is in the same package as the factory I don't see why it should be a String ?
There was a problem hiding this comment.
Good point! Code updated!
There was a problem hiding this comment.
OK, about the JUnit on the classpath, but will the RunnerFactory be used at all then ? The only reasonable use is in the Silent runner class which itself extends the JUnit Runner class.
For maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.