Avoid warning when dynamic attach is enabled #3551

raphw · 2024-12-16T17:51:20Z

Checks the command line arguments for the EnableDynamicAgentLoading argument and does not warn about dynamic attach, if the option is set.

…bled. Add information in readme.

# Conflicts: # mockito-core/src/main/java/org/mockito/internal/PremainAttachAccess.java

codecov-commenter · 2024-12-16T18:27:07Z

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (2e7992b) to head (374c605).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...java/org/mockito/internal/PremainAttachAccess.java	65.00%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3551      +/-   ##
============================================
- Coverage     85.60%   85.55%   -0.05%     
- Complexity     2954     2955       +1     
============================================
  Files           341      341              
  Lines          8976     8995      +19     
  Branches       1118     1119       +1     
============================================
+ Hits           7684     7696      +12     
- Misses         1003     1009       +6     
- Partials        289      290       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ilable due to use of modules, or when running on Android.

mockito-core/src/main/java/org/mockito/internal/PremainAttachAccess.java

TimvdLippe

Nice!

schabe77 · 2025-01-03T13:09:47Z

This doesn't work for me. That's because

mockito/mockito-core/src/main/java/org/mockito/internal/PremainAttachAccess.java

Lines 50 to 55 in e04dbbe

    
           List<String> arguments = 
        
                   (List<String>) 
        
                           runtimeMXBean 
        
                                   .getClass() 
        
                                   .getMethod("getInputArguments") 
        
                                   .invoke(runtimeMXBean);

results in a

java.lang.IllegalAccessException: class org.mockito.internal.PremainAttachAccess cannot access class sun.management.RuntimeImpl (in module java.management) because module java.management does not export sun.management to unnamed module @78b66d36

and therefore in dynamicAgentLoading = false;

But it works, when getInputArguments is requested without Reflection:

        RuntimeMXBean runtimeMXBean = (RuntimeMXBean)
                Class.forName("java.lang.management.ManagementFactory")
                        .getMethod("getRuntimeMXBean")
                        .invoke(null);
       dynamicAgentLoading =
                runtimeMXBean.getInputArguments().stream()
                        .anyMatch(
                                argument ->
                                        argument.contains(
                                                "-XX:+EnableDynamicAgentLoading"));

raphw · 2025-01-03T15:13:52Z

Indeed, this is an annoying implication of the module system if a method is resolved against an overriding class, not the interface. I will need to change that to get the interface class and to invoke the method on it.

raphw · 2025-01-05T20:40:51Z

Suggested fix: #3566

Use interface type for invoking method to avoid that module boundaries are breached when using reflection on internal implementation type. Relates to #3551

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.mockito:mockito-core](https://github.com/mockito/mockito) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.15.2` -> `5.16.0` | | [io.grpc:grpc-stub](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.70.0` -> `1.71.0` | | [io.grpc:grpc-protobuf](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.70.0` -> `1.71.0` | | [io.grpc:grpc-netty](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.70.0` -> `1.71.0` | | [io.grpc:protoc-gen-grpc-java](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.70.0` -> `1.71.0` | | [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.70.0` -> `1.71.0` | | [io.grpc:grpc-api](https://github.com/grpc/grpc-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.70.0` -> `1.71.0` | | [com.google.apis:google-api-services-storage](http://nexus.sonatype.org/oss-repository-hosting.html) ([source](http://svn.sonatype.org/spice/tags/oss-parent-7)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `v1-rev20241206-2.0.0` -> `v1-rev20250224-2.0.0` | | [com.fasterxml.jackson.module:jackson-module-kotlin](https://github.com/FasterXML/jackson-module-kotlin) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.18.2` -> `2.18.3` | | [com.fasterxml.jackson.datatype:jackson-datatype-jsr310](https://github.com/FasterXML/jackson-modules-java8) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.18.2` -> `2.18.3` | | [com.fasterxml.jackson.dataformat:jackson-dataformat-yaml](https://github.com/FasterXML/jackson-dataformats-text) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.18.2` -> `2.18.3` | | [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson) ([source](https://github.com/FasterXML/jackson-databind)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.18.2` -> `2.18.3` | | [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.18.2` -> `2.18.3` | | [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.18.2` -> `2.18.3` | | [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson) ([source](https://github.com/FasterXML/jackson-annotations)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.18.2` -> `2.18.3` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.30` -> `2.30.32` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.30` -> `2.30.32` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.30` -> `2.30.32` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.30` -> `2.30.32` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.30` -> `2.30.32` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.30` -> `2.30.32` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.30` -> `2.30.32` | --- ### Release Notes <details> <summary>mockito/mockito (org.mockito:mockito-core)</summary> ### [`v5.16.0`](https://github.com/mockito/mockito/releases/tag/v5.16.0) <sup><sup>*Changelog generated by [Shipkit Changelog Gradle Plugin](https://github.com/shipkit/shipkit-changelog)*</sup></sup> ##### 5.16.0 - 2025-03-03 - [10 commit(s)](mockito/mockito@v5.15.2...v5.16.0) by Brice Dutheil, Rafael Winterhalter, TDL, dependabot\[bot] - Add support for including module-info in Mockito. [(#3597)](mockito/mockito#3597) - Bump com.gradle.develocity from 3.19 to 3.19.1 [(#3579)](mockito/mockito#3579) - Bump org.assertj:assertj-core from 3.27.2 to 3.27.3 [(#3577)](mockito/mockito#3577) - Bump com.diffplug.spotless:spotless-plugin-gradle from 7.0.1 to 7.0.2 [(#3574)](mockito/mockito#3574) - Bump com.diffplug.spotless:spotless-plugin-gradle from 6.25.0 to 7.0.1 [(#3571)](mockito/mockito#3571) - Bump org.assertj:assertj-core from 3.27.1 to 3.27.2 [(#3569)](mockito/mockito#3569) - Tweaks documentation on mockito agent config for maven [(#3568)](mockito/mockito#3568) - Adds `--info` to diagnose closeAndReleaseStagingRepositories issues [(#3567)](mockito/mockito#3567) - Refine reflection when calling management factory [(#3566)](mockito/mockito#3566) - Avoid warning when dynamic attach is enabled [(#3551)](mockito/mockito#3551) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: b36ad622d93f38a65018855e51bd093a591e512b

raphw added 3 commits November 20, 2024 17:34

Fixes #3512: do not print warning if dynamic attach is explicitly ena…

e01464e

…bled. Add information in readme.

Apply spotless

705263c

Merge branch 'main' into dynamic-attach-warning

d61d9e3

# Conflicts: # mockito-core/src/main/java/org/mockito/internal/PremainAttachAccess.java

raphw added 2 commits December 16, 2024 21:53

Avoid hard dependency on management factory as class might not be ava…

e54b54f

…ilable due to use of modules, or when running on Android.

Avoid hard dependency on management factory as class might not be ava…

048ddd7

…ilable due to use of modules, or when running on Android.

TimvdLippe reviewed Dec 17, 2024

View reviewed changes

mockito-core/src/main/java/org/mockito/internal/PremainAttachAccess.java Show resolved Hide resolved

mockito-core/src/main/java/org/mockito/internal/PremainAttachAccess.java Show resolved Hide resolved

Add test for using enale dynamic agent loading.

374c605

bric3 approved these changes Dec 17, 2024

View reviewed changes

TimvdLippe approved these changes Dec 19, 2024

View reviewed changes

TimvdLippe merged commit cd4704a into main Dec 19, 2024
18 checks passed

TimvdLippe deleted the dynamic-attach-warning branch December 19, 2024 12:56

This was referenced Jan 3, 2025

Bump mockito from 5.14.2 to 5.15.2 kousen/junit5_workshop#238

Merged

Bump org.mockito:mockito-junit-jupiter from 5.14.2 to 5.15.2 kousen/java_8_recipes#120

Merged

This was referenced Mar 3, 2025

Bump mockito from 5.15.2 to 5.16.0 kousen/junit5_workshop#252

Merged

Bump org.mockito:mockito-junit-jupiter from 5.15.2 to 5.16.0 kousen/java_8_recipes#126

Merged

natzei mentioned this pull request Mar 3, 2025

Bump org.mockito:mockito-core from 5.14.2 to 5.16.0 natzei/jvrp#25

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Avoid warning when dynamic attach is enabled #3551

Avoid warning when dynamic attach is enabled #3551

Uh oh!

raphw commented Dec 16, 2024

Uh oh!

codecov-commenter commented Dec 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

TimvdLippe left a comment

Uh oh!

Uh oh!

schabe77 commented Jan 3, 2025 •

edited

Loading

Uh oh!

raphw commented Jan 3, 2025

Uh oh!

raphw commented Jan 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Avoid warning when dynamic attach is enabled #3551

Avoid warning when dynamic attach is enabled #3551

Uh oh!

Conversation

raphw commented Dec 16, 2024

Uh oh!

codecov-commenter commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

TimvdLippe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

schabe77 commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raphw commented Jan 3, 2025

Uh oh!

raphw commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Dec 16, 2024 •

edited

Loading

schabe77 commented Jan 3, 2025 •

edited

Loading

raphw commented Jan 5, 2025 •

edited

Loading