Skip to content

Makes license a convention plugin #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

Makes license a convention plugin #3532

merged 1 commit into from
Dec 9, 2024

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Dec 8, 2024 •
edited
Loading

Following on the trend to follow best practice, the license.gradle script that was using allProject is now a convention plugin, it executes on the following projects.

One step to help on #3474

> Task :mockito-integration-tests:extensions-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:inline-mocks-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:groovy-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:groovy-inline-tests:licenseMain NO-SOURCE
> Task :mockito-extensions:mockito-proxy:licenseMain UP-TO-DATE
> Task :mockito-extensions:mockito-subclass:licenseMain UP-TO-DATE
> Task :mockito-integration-tests:groovy-inline-tests:licenseTest UP-TO-DATE
> Task :mockito-extensions:mockito-proxy:licenseTest UP-TO-DATE
> Task :mockito-extensions:mockito-junit-jupiter:licenseMain UP-TO-DATE
> Task :mockito-integration-tests:groovy-tests:licenseTest UP-TO-DATE
> Task :mockito-extensions:mockito-proxy:license UP-TO-DATE
> Task :mockito-integration-tests:groovy-tests:license UP-TO-DATE
> Task :mockito-integration-tests:groovy-inline-tests:license UP-TO-DATE
> Task :mockito-extensions:mockito-android:licenseMain UP-TO-DATE
> Task :mockito-extensions:mockito-subclass:licenseTest UP-TO-DATE
> Task :mockito-extensions:mockito-subclass:license UP-TO-DATE
> Task :mockito-extensions:mockito-errorprone:licenseMain UP-TO-DATE
> Task :mockito-integration-tests:java-21-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:junit-jupiter-inline-mock-maker-extension-tests:licenseMain NO-SOURCE
> Task :mockito-extensions:mockito-android:licenseTest NO-SOURCE
> Task :mockito-extensions:mockito-android:license UP-TO-DATE
> Task :mockito-integration-tests:junit-jupiter-extension-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:junit-jupiter-parallel-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:inline-mocks-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:inline-mocks-tests:license UP-TO-DATE
> Task :mockito-integration-tests:extensions-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:extensions-tests:license UP-TO-DATE
> Task :mockito-integration-tests:kotlin-release-coroutines-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:kotlin-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:memory-tests:licenseMain NO-SOURCE
> Task :mockito-extensions:mockito-errorprone:licenseTest UP-TO-DATE
> Task :mockito-extensions:mockito-errorprone:license UP-TO-DATE
> Task :mockito-integration-tests:module-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:kotlin-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:kotlin-tests:license UP-TO-DATE
> Task :mockito-integration-tests:osgi-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:junit-jupiter-parallel-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:junit-jupiter-parallel-tests:license UP-TO-DATE
> Task :mockito-integration-tests:programmatic-tests:licenseMain NO-SOURCE
> Task :mockito-integration-tests:memory-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:memory-tests:license UP-TO-DATE
> Task :mockito-integration-tests:programmatic-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:kotlin-release-coroutines-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:module-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:java-21-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:junit-jupiter-inline-mock-maker-extension-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:junit-jupiter-extension-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:osgi-tests:licenseOtherBundle UP-TO-DATE
> Task :mockito-extensions:mockito-junit-jupiter:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:junit-jupiter-inline-mock-maker-extension-tests:license UP-TO-DATE
> Task :mockito-integration-tests:java-21-tests:license UP-TO-DATE
> Task :mockito-extensions:mockito-junit-jupiter:license UP-TO-DATE
> Task :mockito-integration-tests:module-tests:license UP-TO-DATE
> Task :mockito-integration-tests:kotlin-release-coroutines-tests:license UP-TO-DATE
> Task :mockito-integration-tests:programmatic-tests:license UP-TO-DATE
> Task :mockito-integration-tests:junit-jupiter-extension-tests:license UP-TO-DATE
> Task :mockito-integration-tests:osgi-tests:licenseTest UP-TO-DATE
> Task :mockito-integration-tests:osgi-tests:licenseTestBundle UP-TO-DATE
> Task :mockito-integration-tests:osgi-tests:license UP-TO-DATE
> Task :mockito-core:licenseMain UP-TO-DATE
> Task :mockito-core:licenseTest UP-TO-DATE
> Task :mockito-core:licenseTestFixtures UP-TO-DATE
> Task :mockito-core:license UP-TO-DATE

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (6e53f34) to head (063ec8c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #3532   +/-   ##
=========================================
  Coverage     85.64%   85.64%           
  Complexity     2954     2954           
=========================================
  Files           341      341           
  Lines          8972     8972           
  Branches       1116     1116           
=========================================
  Hits           7684     7684           
  Misses         1000     1000           
  Partials        288      288

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bric3 bric3 mentioned this pull request Dec 9, 2024
Merged
8 tasks
@TimvdLippe TimvdLippe merged commit 6cdd4da into main Dec 9, 2024
18 checks passed
@TimvdLippe TimvdLippe deleted the root-gradle-licence branch December 9, 2024 13:33
@bric3 bric3 mentioned this pull request Dec 21, 2024
Closed
2 tasks
This was referenced Jan 3, 2025
Merged
Merged
@natzei natzei mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bric3 @codecov-commenter @TimvdLippe