Convert module build scripts to kotlin script #3514
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3514 +/- ##
============================================
- Coverage 85.59% 85.54% -0.05%
+ Complexity 2952 2951 -1
============================================
Files 341 341
Lines 8967 8967
Branches 1114 1114
============================================
- Hits 7675 7671 -4
- Misses 1007 1010 +3
- Partials 285 286 +1 ☔ View full report in Codecov by Sentry. |
388986f to
2685c34
Compare
testUtil made its usage prone to implicit dependencies, which gradle don't like (for good reason). In particular when related to our mockito-extension test configuration (creates config file before then deletes them after). This line was problematic: `testUtil(sourceSets.test.get().output)` because tasks like `removeTestResources` modified its content.
… using dedicated sourceSet
… using test output builtBy
2685c34 to
927231a
Compare
|
I looked at these changes and tbh, it is difficult to carefully review these as the changes are both syntax as well as behavioral changes. I don't see anything obvious that is wrong, but I also haven't been able to thoroughly review it. So I trust your expertise and due diligence on it, and thus I am okay with merging as-is. |
|
I understand, I propose to merge, and fix anything asap that is broken if any. Thanks for taking the time to look at it ! Since there were a few library update, I need to update those before merging. |
This PR converts groovy build scripts of gradle module to Kotlin (fixes #3445).
Most project were straightforward to convert. Osgi related modules required more attention, due to low expertise on osgi and bnd tooling and, for tests due to some unusual setup. I decided to consolidate some script as it made it easier to grasp the build script.
For
mockito-coreandmockito-junit-jupiterin particular the produced manifest was compared to previous release.Fixed: Java 21 tests some customized tests tasks where not executed.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant