Skip to content

Make spotless config a convention plugin #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2024
Merged

Make spotless config a convention plugin #3508

merged 4 commits into from
Nov 15, 2024

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Nov 14, 2024

Fixes #3473 by moving spotless config to a convention plugin.

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (8a756e1) to head (df4f06d).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #3508   +/-   ##
=========================================
  Coverage     85.59%   85.59%           
  Complexity     2952     2952           
=========================================
  Files           341      341           
  Lines          8967     8967           
  Branches       1114     1114           
=========================================
  Hits           7675     7675           
  Misses         1007     1007           
  Partials        285      285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimvdLippe TimvdLippe merged commit ebec7f2 into main Nov 15, 2024
18 checks passed
@TimvdLippe TimvdLippe deleted the spotless-conventions branch November 15, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make spotless a convention plugin, and fix google java format issue
3 participants
@bric3 @codecov-commenter @TimvdLippe