Skip to content

Mockito issue #3490 #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 7, 2024
Merged

Mockito issue #3490 #3506

merged 7 commits into from
Dec 7, 2024

Conversation

Miguel-Graham
Copy link
Contributor

@Miguel-Graham Miguel-Graham commented Nov 14, 2024 •
edited
Loading

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (3819ca8) to head (6d8acc9).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #3506   +/-   ##
=========================================
  Coverage     85.63%   85.64%           
- Complexity     2953     2954    +1     
=========================================
  Files           341      341           
  Lines          8969     8972    +3     
  Branches       1115     1116    +1     
=========================================
+ Hits           7681     7684    +3     
  Misses         1000     1000           
  Partials        288      288

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TimvdLippe
TimvdLippe requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please run ./gradlew spotlessApply

TimvdLippe
TimvdLippe reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, expect the test expectation which needs to be updated

TimvdLippe
TimvdLippe approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@TimvdLippe TimvdLippe merged commit 6e53f34 into mockito:main Dec 7, 2024
18 checks passed
This was referenced Jan 3, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Miguel-Graham @codecov-commenter @TimvdLippe