Skip to content

Declare android gradle plugins in version catalog #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Nov 8, 2024

Declares com.android.application plugin in version catalog. The current declaration also declares the plugin the legacy way (via buildscript dependencies)

The change follows what is described in Android plugin documentation: https://developer.android.com/build/migrate-to-catalogs

Fixes: #3475

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (582e3fa) to head (4d77154).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3500   +/-   ##
=========================================
  Coverage     85.59%   85.59%           
  Complexity     2952     2952           
=========================================
  Files           341      341           
  Lines          8967     8967           
  Branches       1114     1114           
=========================================
  Hits           7675     7675           
  Misses         1007     1007           
  Partials        285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 8a0aa53 into main Nov 10, 2024
18 checks passed
@TimvdLippe TimvdLippe deleted the android-version-catalog branch November 10, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make android.tools.build.gradle plugin declared in the version catalog
3 participants