Fixes #3469: Prevent NPEs for Disabled Mocks #3476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3476 +/- ##
============================================
- Coverage 85.74% 85.59% -0.16%
- Complexity 2951 2952 +1
============================================
Files 341 341
Lines 8946 8967 +21
Branches 1114 1114
============================================
+ Hits 7671 7675 +4
- Misses 988 1007 +19
+ Partials 287 285 -2 ☔ View full report in Codecov by Sentry. |
This change makes a couple of changes surronding the the clearMock and clearMock() apis. 1. All disabled mocks gets the INSTANCE of DisabledMockCreationSettings. This prevents any NPEs from attempting to access the MockCreationSettings, but will throw a MockDisabledException if attempting to actually read the settings. This will block calls such as: isMock(), etc. 2. This change syncs the logic between the clearMocks() and clearMock() logic to make the customer experience the same whether you are attempting to clear all mocks or just and individual mock.
fd5ad4b to
5186436
Compare
TimvdLippe
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a couple of changes surronding the the clearMock and clearMock apis.
These changes are being made mainly to introduce some more consistent behavior for mocks that have been cleared. Currently, the user experience is less than desirable to have NPEs be tripped depending on which clear method was called on the mock. Additionally, I think this disabling approach brings the design more in-line with some of the documentation about the behavior of a cleared mock.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant