Fix copyMockMethodDispatcher task #2840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task was incorrectly defining inputs and outputs, resulting in the task being marked 'UP-TO-DATE' and not re-running when the input changed or the output was removed. The task now copies the 'raw' file into a new output directory and includes that directory in the jar. This corrects the task inputs and outputs, while also avoiding warnings about shared output directories.
|
@TimvdLippe I believe you changed this code recently. When you have a moment, I'd appreciate a review :) |
|
The changes lgtm, but the build fails on it I think. Not sure what is wrong with it though |
|
Ill take a look in a bit |
|
@TimvdLippe, green build now... |
Codecov ReportBase: 84.84% // Head: 84.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2840 +/- ##
============================================
+ Coverage 84.84% 84.92% +0.07%
- Complexity 2874 2875 +1
============================================
Files 327 327
Lines 8769 8769
Branches 1062 1062
============================================
+ Hits 7440 7447 +7
+ Misses 1052 1046 -6
+ Partials 277 276 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2839
The task was incorrectly defining inputs and outputs, resulting in the task being marked 'UP-TO-DATE' and not re-running when the input changed or the output was removed.
The task now copies the 'raw' file into a new output directory and includes that directory in the jar.
This corrects the task inputs and outputs, while also avoiding warnings about shared output directories.