Deprecate ListUtil and Fields classes #2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
797bbde to
84743b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2593 +/- ##
============================================
- Coverage 86.65% 86.47% -0.18%
+ Complexity 2795 2783 -12
============================================
Files 321 319 -2
Lines 8368 8303 -65
Branches 1024 1011 -13
============================================
- Hits 7251 7180 -71
- Misses 849 858 +9
+ Partials 268 265 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
84743b4 to
4d957e4
Compare
TimvdLippe
reviewed
Mar 15, 2022
There was a problem hiding this comment.
With "Android users", I meant those that are using Mockito on older versions of Android that does not support lambda's and all. However, these projects can desugar, which might solve the problem.
Therefore, if we are still compatible with Android SDK 24 (I believe that's the version we use), I think we can merge this as-is. Let's see what CI says.
TimvdLippe
requested changes
Mar 15, 2022
src/main/java/org/mockito/internal/invocation/InvocationsFinder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mockito/internal/util/collections/ListUtil.java
Outdated
Show resolved
Hide resolved
4d957e4 to
97f4841
Compare
97f4841 to
b58eeb8
Compare
TimvdLippe
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1926.