Fixes #1183: Make override check more forgiving to accomondate Kotlin compile patterns. #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compile patterns.
Codecov Report
@@ Coverage Diff @@
## release/2.x #1217 +/- ##
=================================================
- Coverage 87.32% 87.27% -0.05%
+ Complexity 2304 2301 -3
=================================================
Files 287 287
Lines 5855 5856 +1
Branches 696 696
=================================================
- Hits 5113 5111 -2
- Misses 555 556 +1
- Partials 187 189 +2
Continue to review full report at Codecov.
|
TimvdLippe
approved these changes
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override check implies Java compile patterns such that Kotlin method resolutions could fail for void return types which do not fit into Java's reference-type only generic hierarchies. This PR eases this restriction to fix this resolution for Kotlin.
I added the test case of the reported issue as a reference.