-
Notifications
You must be signed in to change notification settings - Fork 203
Upgrade Kotlin and Gradle #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current CI failure seems to be a random failure that probably needs to be rerun? |
I have rerun it on CI a couple of times and it appears to consistently fail. Please investigate the failure and let us know why it is failing. |
The I am not deep enough in this codebase to understand what |
I had another look at it but it almost feel like maybe the test is not correct. Why did |
@TimvdLippe would you perhaps be able to take a look at this? |
Unfortunately I am not versed in Kotlin, so I can't assist with investigating Kotlin specific failures. Maybe somebody else with more knowledge of the Kotlin compiler can help out? It's not the first time Kotlin does something that is unusual compared to the other JVM languages. |
I think I agree with this assessment, especially because the |
@TimvdLippe I removed the broken test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all for the assistance! I will publish a new version of mockito-kotlin
with this change.
The verification fails on `main`, even though the run in #535 was green.
The verification fails on `main`, even though the run in #535 was green. Probably because the action version had to be updated as well.
This is a followup of #534 (review)
It upgrades Kotlin and Gradle to a newer version.
These are some pretty major upgrades so I do recommend also locally testing it before approving/merging.