docs: Deploy new site alongside old one #5360
Merged
+341
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got some problems to solve :) https://deploy-preview-5360--mocha.netlify.app/next/ |
Only applies to Netlify builds, it looks like
|
Excellent! |
JoshuaKGoldberg
approved these changes
May 12, 2025
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Adds
build-with-oldto the new site andbuild-newto the old site to merge the two seamlessly. Also addshttp-serverfor the newdocs:previewcommand that allows devs to test the old site, especially alongside the new site.Pins Node to v20 for LTS support in netlify.toml. Default was v16 for some reason after unpinning entirely. v16 is not supported by Astro.
Unpins Ruby versions for the site builder. Ruby was pinned in 2020 but I don't think we need to pin it anymore. It's likely not being used at all as our only Netlify steps are npm scripts.
Does not add any sort of banner or link between the two sites, users will have to manually type in
mochajs.org/nextto see the new site. Ref 📝 Docs: Add a banner/notice to the current site linking to the new site #5304 for that work.Does not remove the
netlify.tomlor "unused" npm scripts in the docs-next folder. That will be done in a cleanup PR once we're certain those resources are not needed any more.