fix: switch from ansi-colors to picocolors #5323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-wiemer
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the ansi-colors dependency with picocolors across the CLI to reduce package size and maintain a drop-in API compatibility.
- Removed
ansi-colorsand addedpicocolorsinpackage.json - Updated all CLI modules to
require('picocolors')and swappedansi.*calls forpc.*
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed ansi-colors and added picocolors dependency |
| lib/cli/run.js | Swapped ansi.red → pc.red for error output |
| lib/cli/run-helpers.js | Swapped ansi.yellow → pc.yellow for warnings |
| lib/cli/options.js | Swapped ansi.red → pc.red for parse errors |
| lib/cli/collect-files.js | Swapped ansi.red/ansi.yellow → pc.red/pc.yellow |
| lib/cli/cli.js | Swapped multiple ansi.* calls in error handlers and epilog |
Comments suppressed due to low confidence (3)
lib/cli/run.js:11
- [nitpick] The alias
pcis short and may be unclear to future readers; consider renaming it tocolorsorpicocolorsfor better readability.
const pc = require('picocolors');
lib/cli/collect-files.js:5
- [nitpick] Consistent naming across files improves maintainability; consider using a clearer alias like
colorsinstead ofpc.
const pc = require('picocolors');
lib/cli/run.js:360
- There are no existing tests validating CLI error output formatting; consider adding a test to assert that error messages are correctly colored with
picocolors.
console.error(`\n${symbols.error} ${pc.red('ERROR:')}`, err);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Per the issue, switches from
ansi-colorsto the smallerpicocolorsfor colorization. It seems to be a drop-in replacement.